test(cockpit-e2e-wiring): scope:* tag drift-guard (PR 3/3)#509
Merged
Conversation
PR 3 of 3 for the ci-scope thin-shim migration. PR 1 (#503) added scope:* tags to every CI-participating project; PR 2 (#507) rewrote ci-scope.mjs to read them via `nx show projects --affected --json`. This drift-guard asserts every cockpit cap project (angular + python under cockpit/<product>/<topic>/) declares the expected tags: - scope:cockpit-e2e + scope:cockpit-examples on every cap project. - scope:cockpit-smoke on python caps that have a smoke target. Closes the silent-failure mode: future contributors adding a new cap can't forget the tags — the test names which project + which tag is missing. Excludes cockpit/ag-ui/* (no python sibling; different tag rules). See spec: docs/superpowers/specs/2026-05-21-ci-scope-thin-shim-design.md. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR 3 of 3 for the ci-scope thin-shim migration. Adds a third `it()` block to `apps/cockpit/cockpit-e2e-wiring.spec.ts` asserting that every cockpit cap project declares the `scope:*` tags the shim relies on.
What it guards against
Without this, a future contributor adding a new cap could silently forget the tags — their CI would underfire and we'd only catch it when something breaks downstream.
Closes the migration arc
Test plan
🤖 Generated with Claude Code